db-operator / charts

db-operator Helm charts repository
3 stars 2 forks source link

dependency on cert-manager #20

Open bit-herder opened 11 months ago

bit-herder commented 11 months ago

Hi I noticed when installing this on a cluster that there is an implicit dep on cert-manager. Maybe you guys should add that to the chart deps? Its pretty plain in the values file but its undocumented beyond that I think. Also, we have the webhook creation set to false but this logic is still being triggered and we cannot install without first installing cert-manager. Thats fine, but its good to know for dependencies.

bit-herder commented 11 months ago

I was able to find a way out of this personally but I think its still a dep.

I can disable the webhook and get a working install without cert-manger with:

  values:
    webhook:
      enabled: false
      certificate:
        create: false
        issuer: 
          create: false 
allanger commented 9 months ago

I haven't seen this issue, I guess. Yes, it's a dependency, but helm dependencies is a bad way to define actual dependencies, because it's just something to be installed alongside the main chart.

I want to make the chart independent of cert-manager one day. So I'll reopen this issue.