search

db-tu-dresden / TSL

Template SIMD Library (+Generator)
GNU General Public License v3.0
7 stars 8 forks source link

Different requirement for test cases lead to multiple definitions of the same test case #31

Closed JPietrzykTUD closed 1 year ago

JPietrzykTUD commented 1 year ago

If the requirements differ for multiple tests of primitive, multiple test cases are generated (with the same test identifier).

alexKrauseTUD commented 1 year ago

I tried replicating this issue based on https://github.com/DerTuchi/TVLGen/commit/6bf7c99fb9e4aa20257e13d85c9cc8a63dfec9a4. However, when I moved the specific yaml file to an up-to-date version of the current generator, the duplication error did not persist. Can someone else replicate the problem one a clean state?

DerTuchi commented 1 year ago

I just made a fresh clone of main and removed the "loadu" requirement in the first testcase from "add" and get the error. (Test1_requirements: [ "set1" ]; Test2_requirements: [ "set1", "loadu" ]) However when I remove "set1" in one testcase there is no problem. (Test1_requirements: [ "loadu" ]; Test2_requirements: [ "set1", "loadu" ]) Also when I add one more requirement there is also no error appearing. (Test1_requirements: [ "set1", "loadu", "storeu" ]; Test2_requirements: [ "set1", "loadu" ]) Maybe it has something todo with the "loadu"?

alexKrauseTUD commented 1 year ago

Solved with PR #45.