db-ui / elements

Web Components, based on DB UI Core.
https://db-ui.github.io/elements/
Apache License 2.0
46 stars 9 forks source link

Version 0.30.0: Could not resolve "@db-ui/ngx-elements-enterprise/dist/lib" #2606

Closed jonaskuske closed 2 months ago

jonaskuske commented 3 months ago

In versions 0.29.3 and below, @db-ui/ngx-elements-enterprise included a separate package.json in dist/lib that pointed at the entry file(s), so that the following import worked (as suggested by the docs):

import { DBUIElementsModule } from '@db-ui/ngx-elements-enterprise/dist/lib';

Now in version 0.30.0, this package.json is missing. As there's also no index.js, the import from dist/lib can not be resolved and the application build errors:

Application bundle generation failed. [4.257 seconds]

✘ [ERROR] Could not resolve "@db-ui/ngx-elements-enterprise/dist/lib"

    src/app/app.module.ts:13:35:
      13 │ ...UIElementsModule } from '@db-ui/ngx-elements-enterprise/dist/lib';
mfranzke commented 2 months ago

@jonaskuske thanks a lot for your feedback. We've just released a possible solution within a prerelease with the @next tag as version 0.30.1-0-7bca155. Could you please do us a favour and check that version for whether it solves your problem?

jonaskuske commented 2 months ago

@mfranzke Thanks! I just tested it, unfortunately it doesn't work. 🙁

(and if you check https://unpkg.com/browse/@db-ui/ngx-elements-enterprise@0.30.1-0-7bca155/dist/lib/, there's still neither an index.js nor a package.json, so the import from there can't be resolved)

mfranzke commented 2 months ago

@nmerget I think that you might have thought about your solution a little differently. Could you please come back to this aspect and further explain ?

mfranzke commented 2 months ago

@mfranzke Thanks! I just tested it, unfortunately it doesn't work. 🙁

(and if you check https://unpkg.com/browse/@db-ui/ngx-elements-enterprise@0.30.1-0-7bca155/dist/lib/, there's still neither an index.js nor a package.json, so the import from there can't be resolved)

@jonaskuske The package.json is back at its expected place. Could you please retest with version 0.30.1-2-003f1c3?

jonaskuske commented 2 months ago

@mfranzke 0.30.1-2-003f1c3 works 👍

mfranzke commented 2 months ago

@mfranzke 0.30.1-2-003f1c3 works 👍

great, thanks. I've started the release pipeline for a patch release with version 0.30.1