Closed nmerget closed 11 months ago
@nmerget I'm struggling whether it makes sense to check in the transformed files, or instead keep in the URLs, and only have those rewrites being done during build for the GitHub Pages exclusively – both because we only need them on this environment and we could even also keep dynamic contents like we would need them for items like this: https://github.com/db-ui/mono/pull/1283#discussion_r1266416265
@nmerget I'm struggling whether it makes sense to check in the transformed files, or instead keep in the URLs, and only have those rewrites being done during build for the GitHub Pages exclusively – both because we only need them on this environment and we could even also keep dynamic contents like we would need them for items like this: #1283 (comment)
So it's fine to have those links (shield.io) on the default readme on GitHub?
@nmerget I'm struggling whether it makes sense to check in the transformed files, or instead keep in the URLs, and only have those rewrites being done during build for the GitHub Pages exclusively – both because we only need them on this environment and we could even also keep dynamic contents like we would need them for items like this: #1283 (comment)
So it's fine to have those links (shield.io) on the default readme on GitHub?
yes, because they do a similar transformation by themselves to display them on GitHub.com, compare to e.g. https://github.com/db-ui/core
Sorry that this hasn't been mentioned on your changes with https://github.com/db-ui/mono/pull/1239 already – so sad that we cannot reproduce who has reviewed and approved that previous change …
🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/fix-issue-with-md-files