db-ui / mono

DB UX Design System Monorepo - Provides Design Tokens and components for Web UIs
https://db-ui.github.io/mono/review/main/
Apache License 2.0
34 stars 6 forks source link

fix: issue with patternhub not having a fallback for `not found` pages #1573

Closed nmerget closed 9 months ago

nmerget commented 9 months ago

Proposed changes

Fix issue for Marketingportal, resolves https://github.com/db-ui/mono/issues/1546

Types of changes

Further comments

github-actions[bot] commented 9 months ago

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/fix-patternhub-redirect-404

mfranzke commented 9 months ago

@nmerget shouldn't this lead to that https://db-ui.github.io/mono/review/fix-patternhub-redirect-404/components/button/?page=state redirects to https://db-ui.github.io/mono/review/fix-patternhub-redirect-404/components/button/overview?page=state (which it doesn't at the moment)?

mfranzke commented 9 months ago

@nmerget https://db-ui.github.io/mono/review/fix-patternhub-redirect-404/components/button/?page=state still doesn't work, only https://db-ui.github.io/mono/review/fix-patternhub-redirect-404/components/button?page=state does now.

nmerget commented 9 months ago

https://db-ui.github.io/mono/review/fix-patternhub-redirect-404/components/button/?page=state

This is not a vaild URL. And the Marketingportal is not using this, so we are fine here

image

mfranzke commented 9 months ago

https://db-ui.github.io/mono/review/fix-patternhub-redirect-404/components/button/?page=state

https://db-ui.github.io/mono/review/fix-patternhub-redirect-404/components/button/?page=state -> this actually is a valid URL, compare to e.g. https://db-ui.github.io/elements/?path=/story/00-intro-welcome--page, which is resolving to https://db-ui.github.io/elements/index.html?path=/story/00-intro-welcome--page

And https://db-ui.github.io/mono/review/main/components/button?page=tonality is what's among other currently in use within the Marketingportal pages: