several component pages are missing

db-ui / mono

DB UX Design System Monorepo - Provides Design Tokens and components for Web UIs

https://db-ui.github.io/mono/review/main/

Apache License 2.0

32 stars 6 forks source link

several component pages are missing #1762

Closed mfranzke closed 3 months ago

mfranzke commented 7 months ago

Which generators are impacted?

[X] All
[ ] HTML
[ ] React
[ ] Angular
[ ] Vue
[ ] Web components
[ ] Power Apps

Reproduction case

The brand overview page is missing. Open https://db-ui.github.io/mono/version/v0.0.57/components/brand/overview

Expected Behaviour

The page would get displayed.

Screenshots

No response

Browser version

None

Add any other context about the problem here.

No response

mfranzke commented 7 months ago

@snahn2209 could you please add further findings here?

snahn2209 commented 7 months ago

Reproduction case

The brand overview page is missing. Open https://db-ui.github.io/mono/version/v0.0.57/components/brand/overview

Also missing:

[ ] header overview (https://db-ui.github.io/mono/review/main/components/header/overview)

[ ] page overview (https://db-ui.github.io/mono/review/main/components/page/overview)

[ ] icon overview (https://db-ui.github.io/mono/review/main/components/icon/overview)

d-koppenhagen commented 3 months ago

Updated list off missing components:

d-koppenhagen commented 3 months ago

Okay, it seems like only the overview page with live demo of this component isn't generated as the related React-Component is used here. The code for this is in showcases/patternhub/scripts/generate-docs-mdx.js:

if (reactComponent) {
  FS.writeFileSync(
    `${componentPath}/overview.tsx`,
    reactComponent
  );
  FS.writeFileSync(`${componentPath}/index.tsx`, reactComponent);
} else {
  console.log('NOT A REACT COMPONENT!!!! ', componentPath, componentName)
}