fix: removed bad a11y issue from popover

db-ui / mono

DB UX Design System Monorepo - Provides Design Tokens and components for Web UIs

https://db-ui.github.io/mono/review/main/

Apache License 2.0

34 stars 6 forks source link

fix: removed bad a11y issue from popover #1767

Closed nmerget closed 7 months ago

nmerget commented 7 months ago

Proposed changes

Types of changes

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring (fix on existing components or architectural decisions)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Further comments

github-actions[bot] commented 7 months ago

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/fix-popover-a11y-issue

mfranzke commented 7 months ago

@nmerget this does remove the testing all at once; to my understanding, this issue is actually a false positive, as it's identifying the colors incorrectly, isn't it? So deactivating doesn't necessarily feel like a good / final solution to me; we might have other unidentified issues and would also need to analyze why this is reporting incorrectly, as removing that test could only be a temporary hack.

mfranzke commented 7 months ago

… and for whatever reason, even with the test included again, this didn't break anymore: https://github.com/db-ui/mono/pull/1763/checks

mfranzke commented 7 months ago

@nmerget are you still working on this feature in the connected branch? Or is it that you don't follow up on this topic at all? In case of the latter, you could even also delete the branch via that button in the PR:

nmerget commented 7 months ago

We can close the branch as well. I think this was some other issue and we can keep the test as it is