feat: add simple outside of viewport handling for navigation item

nmerget commented 4 months ago

Proposed changes

The navigation was very simple without any JS to check the boundaries of the viewport. This is a simple solution to check if a sub-navigation is outside of the viewport.

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Refactoring (fix on existing components or architectural decisions)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Further comments

github-actions[bot] commented 4 months ago

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/feat-outside-handling-sub-navigation

mfranzke commented 2 months ago

@nmerget is this PR obsolete?

nmerget commented 2 months ago

Somehow it's already merged. But the functionality isn't working :S

mfranzke commented 2 months ago

Somehow it's already merged. But the functionality isn't working :S

"somehow" it seems to have been integrated with this commit: https://github.com/db-ui/mono/commit/1803f94d10c5ad65f6d3569bbd64dfd69ee2cc0e it's nice that we could have blamed it this time … ;-)

nmerget commented 2 months ago

Already merged to main

db-ui / mono