db-ui / mono

DB UX Design System Monorepo - Provides Design Tokens and components for Web UIs
https://db-ui.github.io/mono/
Apache License 2.0
66 stars 7 forks source link

DBButton: empty prop `variant=""` creates unexpected combination of variants filled and outlined #2444

Open mfranzke opened 7 months ago

mfranzke commented 7 months ago

Which generators are impacted?

Reproduction case

empty prop variant="" creates unexpected combination of variants filled and outlined

Expected Behaviour

tbd

Screenshots

No response

Browser version

None

Add any other context about the problem here.

No response

nmerget commented 7 months ago

@bruno-sch is it only in vue or can we reproduce it here?

bruno-sch commented 7 months ago

@nmerget yes, this bug can be reproduced in any framework or just by using html + css.

nmerget commented 7 months ago

@nmerget yes, this bug can be reproduced in any framework or just by using html + css.

If I open https://db-ui.github.io/mono/review/main/components/button/overview and change it in the dom nothing happens

bruno-sch commented 7 months ago

Sorry, my mistake: you have to use data-variant="" to see the bug. But anyway, I've already fixed the bug and linked the PR...

Bildschirmfoto 2024-04-15 um 17 14 07