Feat navigation add save triangle pattern

db-ui / mono

DB UX Design System Monorepo - Provides Design Tokens and components for Web UIs

https://db-ui.github.io/mono/review/main/

Apache License 2.0

27 stars 5 forks source link

Feat navigation add save triangle pattern #2560

Closed bruno-sch closed 2 weeks ago

bruno-sch commented 3 weeks ago

Proposed changes

Types of changes

Fixes: #2196

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Refactoring (fix on existing components or architectural decisions)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Further comments

github-actions[bot] commented 3 weeks ago

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/feat-navigation-add-save-triangle-pattern

mfranzke commented 3 weeks ago

@bruno-sch the way from the navigation item to a subitem now feels amazing, but it felt a little strange when going back from the subitem to the "parent" item, not being able to move to the next item below because of the triangle. So it actually does a great job when moving "down", but when moving back up one level again e.g. to select another one, we might have to think about whether we disable the triangle after the user has reached the subitems.