Fix a11y form component ids

db-ui / mono

DB UX Design System Monorepo - Provides Design Tokens and components for Web UIs

https://db-ui.github.io/mono/review/main/

Apache License 2.0

27 stars 5 forks source link

Fix a11y form component ids #2599

Open nmerget opened 2 weeks ago

nmerget commented 2 weeks ago

Proposed changes

closes #2588

[x] changed form-components to work with aria-describedby and messages
[x] add new showcase tests to check if every framework works with every specific form implementation to make sure nothing breaks

Types of changes

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring (fix on existing components or architectural decisions)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Further comments

github-actions[bot] commented 2 weeks ago

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/fix-a11y-form-component-ids

mfranzke commented 1 week ago

as another optimization we should evaluate to only insert the texts into the related description HTML tags to enable status messages being articulated by screenreaders, with further role=status and role=alert added to those HTML tags.

mfranzke commented 1 week ago

as another optimization we should evaluate to only insert the texts into the related description HTML tags to enable status messages being articulated by screenreaders, with further role=status and role=alert added to those HTML tags.

I've opened another issue for this optimization, to get this fix out of the door and provide that other optimization afterwards: https://github.com/db-ui/mono/issues/2624