search

db-ui / mono

DB UX Design System Monorepo - Provides Design Tokens and components for Web UIs
https://db-ui.github.io/mono/review/main/
Apache License 2.0
32 stars 6 forks source link

feat(component): Radio #517

Closed mfranzke closed 1 year ago

mfranzke commented 1 year ago

Resolves https://github.com/db-ui/mono/issues/361

github-actions[bot] commented 1 year ago

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/361-featcomponent-radio

mfranzke commented 1 year ago

@nmerget somehow the styles by the .example-list tend to let the radio elements increase in width: https://db-ui.github.io/mono/review/361-featcomponent-radio/components/radio/examples

image
nmerget commented 1 year ago

@nmerget somehow the styles by the .example-list tend to let the radio elements increase in width: https://db-ui.github.io/mono/review/361-featcomponent-radio/components/radio/examples

image

This was just a quick overview for all combinations. Maybe a https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dl?retiredLocale=de would be better here to have a default behaviour

mfranzke commented 1 year ago

@nmerget somehow the styles by the .example-list tend to let the radio elements increase in width: https://db-ui.github.io/mono/review/361-featcomponent-radio/components/radio/examples

image

This was just a quick overview for all combinations. Maybe a https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dl?retiredLocale=de would be better here to have a default behaviour

fixed by https://github.com/db-ui/mono/pull/610

mfranzke commented 1 year ago

on hold until we fix the ref topic. @nmerget