db-ygoresources-com / yugioh-card-history

25 stars 2 forks source link

Dark Begining 2 set code discrepancy #1

Closed LordChunder closed 2 years ago

LordChunder commented 2 years ago

The set data for Dark Beginning 2 is coded 'DB'. Some cards within the dataset have their set variants coded as 'DB2' whereas others have this coded as 'DB'. I believe every instance of dark beginning 2 should be set coded 'DB2'

gallantron commented 2 years ago

Hi, can you give an example of this happening? When it does, can you click through to the official database (click in the printed date) and verify that the data we display does reflect what is shown on the official database?

LordChunder commented 2 years ago

SmartSelect_20221115_110916_YuGiOh! Tools Screenshot_20221115-110829_YuGiOh! Tools

You can see that when looking through the set list. "Dark beginning 2" set code is "DB" When looking up cards within db2 such as a legendary ocean. We can see the card belongs to 2 set lists. Both DB and DB2. I do not believe there is a DB set list only DB1 and DB2.

gallantron commented 2 years ago

That UI isn't anything we've made. I assume that's something you've made yourself? What data is it using?

gallantron commented 2 years ago

A Legendary Ocean only lists DB2 set codes on its API page. I'm not sure what data you are using, but it's probably not ours.

LordChunder commented 2 years ago

Yike that is embarrassing. You are right. The urls are very close. Sorry for taking your time and thank you for clarifying. I am glad I stumbled across another repository.