db0 / Android-Netrunner-OCTGN

The Game Definition for the Android:Netrunner LCG OCTGN plugin
http://octgn.gamersjudgement.com/viewforum.php?f=52
87 stars 36 forks source link

Lucky Find has Criminal Influence #424

Closed ArchmageBB closed 10 years ago

ArchmageBB commented 10 years ago

Lucky Find has Criminal Influence when it should have none.

SleepyBrett commented 10 years ago

It should have influence.

On Apr 13, 2014, at 4:49 PM, Aaron Kingery notifications@github.com wrote:

Lucky Find has Criminal Influence when it should have none.

— Reply to this email directly or view it on GitHub.

db0 commented 10 years ago

I think they mean it has crim influence when it should have neutral influence.

SleepyBrett commented 10 years ago

I'm just checking through the code (events.py.. line 102) ...

      if num(card.Influence) and card.Faction != Identity.Faction:
     if Identity.model == 'bc0f047c-01b1-427f-a439-d451eda03029' and card.Type == 'Program' and card.model not in professorsRig:
        debugNotify("adding {} to prof. rig. card type = {}".format(card,card.Type))
        professorsRig.append(card.model) # First instance of a card is free of influence costs.
     else: 
        debugNotify("adding influence of {}. card type = {}".format(card,card.Type))
        loInf += num(card.Influence)

And from the set:

<card id="bc0f047c-01b1-427f-a439-d451eda04109" name="Lucky Find">
...
  <property name="Faction" value="Neutral" />
  <property name="Influence" value="2" />
...
</card>

I'm not in a position to test it, but assuming it makes it down to the influence counting subroutine I can't see why it wouldn't be counted properly. If you identity is Criminal then card.faction != identity.faction, and we're not professor and it's not a program, count the influence.

Can the OP provide a test case?

db0 commented 10 years ago

Huh, if it's set as Neutral in the xml then yeah it shouldn't be a problem.

ArchmageBB commented 10 years ago

I believe you are correct. Thank you for your effort. It is really a card image problem and not database/game play.

On Mon, Apr 14, 2014 at 12:11 PM, Divided by Zer0 notifications@github.comwrote:

Huh, if it's set as Neutral in the xml then yeah it shouldn't be a problem.

— Reply to this email directly or view it on GitHubhttps://github.com/db0/Android-Netrunner-OCTGN/issues/424#issuecomment-40385110 .