search

db0 / Android-Netrunner-OCTGN

The Game Definition for the Android:Netrunner LCG OCTGN plugin
http://octgn.gamersjudgement.com/viewforum.php?f=52
87 stars 36 forks source link

Off-campus apartments never behaves correctly #630

Closed jemeador closed 9 years ago

jemeador commented 9 years ago

Installing from hand always costs a click and no credits (should cost credits as well). Hosting a connection already on the table costs a click and no credits (shouldn't cost a click). Hosting an installed connections doubles the number of recurring credits on the connection.

The above behaviors are bugs themselves, but other properties of off-campus make it difficult to play as well. It makes your board an unorganized mess, especially if supplier is installed on off-campus as well. Off-campus should behave similarly to Scheherazade, where counters are used to track hosting of cards in play and moving the host doesn't reposition hosted cards.

db0 commented 9 years ago

I'll take a look when I'm done with the 100 new cards :)

jemeador commented 9 years ago

I'm eagerly awaiting my new tenants Mr. Drug Dealer and Ms. Film Critic. Is there any way for me to more directly contribute?

db0 commented 9 years ago

Do you know any python? :)

jemeador commented 9 years ago

I've used it before. I'd love to play with it again just to get some experience. Point me at some instructions for testing changes in OCTGN and I'll give it a shot.

jemeador commented 9 years ago

Looking at customscripts.py, I've identified a number of problems:

I have an idea of what lines should be changed, should I just submit a pull request and let you test them?

db0 commented 9 years ago

Sure, go for it :) I can show you later how you can test it yourself on your end before sending a pull request.

On Thu, 13 Aug 2015 at 01:06 jemeador notifications@github.com wrote:

Looking at customscripts.py, I've identified a number of problems:

  • Off-campus shouldn't always require a click to use (even if we moved that early abort to install from hand, there are conditions that would allow the runner to install from hand without using a click (Haley ability)).
  • The cost of a card is never considered when installing from the grip
  • The install script is run for cards that have already been installed. This could be problematic for cards that need to be moved onto Off-campus post-install (muertos, scrubber, inside man, peddler). This should be only run under the condition that the card is coming from the grip.
  • Hosted cards are explicitly disalowed from being hosted on Off-campus, despite it being a valid action (installing from the supplier or peddler). This may be trickier to implement correctly due to reduced costs and isn't required as long as installing from the table works correctly.

I have an idea of what lines should be changed, should I just submit a pull request and let you test them?

— Reply to this email directly or view it on GitHub https://github.com/db0/Android-Netrunner-OCTGN/issues/630#issuecomment-130473061 .