db0 / godot-card-game-framework

A framework which comes with prepared scenes and classes to kickstart your card game, as well as a powerful scripting engine to use to provide full rules enforcement.
http://dbzer0.com/projects/godot-card-game-framework/
GNU Affero General Public License v3.0
948 stars 100 forks source link

Exported Deck Pile Labels #108

Closed zombieCraig closed 3 years ago

zombieCraig commented 3 years ago

Exports a Deck Label so you can easily label your deck piles from your Board scene.

db0 commented 3 years ago

But, you can do that anyway, by changing its label text :) You just want something more obvious? I'm asking because this is not as simple as it appears. If you change the name of the pile like that, the developer will probably also assume that there's some symmetry. I.e. if they change the label, they would also expect the var to change. And what if they change the var but the node name remains the same? Should we be renaming the node name too? Some things to consider.

zombieCraig commented 3 years ago

Personally I didn't find it obvious on where to control the label. Since I had to create several piles my workflow as to:

You are correct that this PR is not a bug fix but a quality of life improvement.

db0 commented 3 years ago

I decided to merge this, for potential ease of use. Let's see if it's useful or confusing.