search

db0 / godot-card-game-framework

A framework which comes with prepared scenes and classes to kickstart your card game, as well as a powerful scripting engine to use to provide full rules enforcement.
http://dbzer0.com/projects/godot-card-game-framework/
GNU Affero General Public License v3.0
891 stars 95 forks source link

a godot 4 version? #178

Open linyangqi opened 1 year ago

linyangqi commented 1 year ago

Hi, dbzer0, I admire your work very much XD Actually I'm wanting to make a godot version of a board game named "boardgame is magic". It's a mlp (my little pony) fan-made game, and already have physical cards to play, but still have not get digital version, so I'm using godot to make it. However, this board game contains hexagon tiled maps, so I'd prefer to make it in godot 4, where Tilemap has been well-upgraded. Here's what I've got till now: https://github.com/linyangqi/board_game_is_magic-demo

But I think I've got stuck constructing the framework.... Someone recommended your project to me, so I'd like to try using your framework for my work XD Still I haven't fully understand how your framework works, but I'm learning from it. Besides, I found that your project now runs in godot 3, so I'd like to try forking a godot 4 version. Here's the link: https://github.com/linyangqi/godot-card-game-framework-gd4 Wish if you have any advice for it XD Thanks a lot!

db0 commented 1 year ago

Thanks mate. At the moment I am very busy with the AI horde so I do not have time for this. But I hope you make it work and then send me a PR :)

linyangqi commented 1 year ago

Thank you XD I will try my best!

InfiniteProductions commented 1 year ago

Any update ?

The project looks good but after I look into the only CardTemplate.gd (in src/core), it appears to be a very tough job to convert this project to Godot 4, for instance, there are a lot of coroutines, a trick overriding set_name of Node(2D) class with canonical name which won't work any more cause of Godot issue 55024.

I think this project is become too big and it won't pretty much never be converted well to 4.0 unless a massive effort from a few people with deep knowledge of 4.0 update and strong will to do the job, sadely.

Converting some class here or there would be more or less ok but there is no warranty it won't break something else in another part of the project and so on, leading to a nightmare. Redoing it from scratch may be the best option.

db0 commented 1 year ago

It's something I would like to do at some point, but currently and unfortunately my attention is taken wholly by my other project, the AI Horde. So unless someone can step up, I don't see it happening in the foreseeable future.

rngesus-wept commented 8 months ago

Can you create a public branch godot-4.0-conversion or similar so that any conversion work can be centralized, even if it's not complete?

db0 commented 8 months ago

Done https://github.com/db0/godot-card-game-framework/tree/godot4-conversion