Closed vmjcv closed 3 years ago
Looks good, but I would like to ask that in the future you also try to include some GUT tests for new functionality. I.e. you could add a test that check all individual buttons have been modulated in/out, one that checks that manipulation_buttons_self
is being populated etc.
I will do this later for this change, but it helps when I don't have to :)
This change needed a bit of work to fit the standard I'm expecting. I've done the modifications so you could view them as an example: Please see https://github.com/db0/godot-card-gaming/commit/eefb945840efbd615a427a7235309e0a4460f398 for the sort of quality I expect. Specifically please try to provide the following in your pull requests
I know it's a lot more work, but it significantly improves quality, troubleshooting and readability.