search

db0 / godot-card-game-framework

A framework which comes with prepared scenes and classes to kickstart your card game, as well as a powerful scripting engine to use to provide full rules enforcement.
http://dbzer0.com/projects/godot-card-game-framework/
GNU Affero General Public License v3.0
907 stars 96 forks source link

add_oval_card_test #76

Closed vmjcv closed 3 years ago

vmjcv commented 3 years ago
  1. Add code comments
  2. Change parameters
  3. change test script
db0 commented 3 years ago

Unfortunately, try as I might, I could not get this to work, and I didn't have write access to your repo to push my rebased-from-scratch branch. In the end I created a branch on my own side

https://github.com/db0/godot-card-gaming/pull/77

If you ever end up in this situation again, I suggest you make a copy of your repo while on this branch, then create a fresh branch and copy back the files into that. That will effectively work as a rebase as well.

vmjcv commented 3 years ago

ok,it is good