dbachelder / CreditCardEntry

Smooth UI for Credit Card Entry on Android device, regex check for supported credit card types and luhn check. Inspired by Square credit card entry interface
MIT License
503 stars 166 forks source link

Took out icon to avoid unnessecary Manifest Merger failures #13

Closed CapitanRedBeard closed 9 years ago

CapitanRedBeard commented 9 years ago

No need for an android icon on a library, and it just causes a bug so its got to go!

dbachelder commented 9 years ago

@CapitanRedBeard Thanks for the PR!

I think there is some confusion here... hard to say with all the extra commits in this PR.

I removed the launcher icon back in april:

https://github.com/dbachelder/CreditCardEntry/commit/c506433a5932c58286264589f608b7c3eb1e9e75

Is there anything else in this PR?

CapitanRedBeard commented 9 years ago

Yeah sorry, didnt mean to make a pull request. I'll try out 1.3 and get back to you, thanks for the quick response! I was on 1.2.1 btw