dbachelder / CreditCardEntry

Smooth UI for Credit Card Entry on Android device, regex check for supported credit card types and luhn check. Inspired by Square credit card entry interface
MIT License
503 stars 166 forks source link

isCreditCardValid returns true after editing number to be incorrect #32

Closed mhousser closed 9 years ago

mhousser commented 9 years ago

After the form is correctly filled out, and isCreditCardValid correctly returns true, I'm able to click on the credit card number, erase a bunch of the numbers (thus rendering the number incorrect), focus on some other field on the screen, and have isCreditCardValid still return true (when, in fact, I had expected it to return false).

I'm working with Stripe, which went on to fail because the data in the CreditCardForm was actually invalid at that point.

dbachelder commented 9 years ago

good catch. fixed in 1.4.6