Closed Mr0grog closed 2 years ago
FYI, you can see the errors listed out in the CI logs, but since we are on GitHub actions, itāll also list the errors right in the āfiles changedā tab of the PR. š
(Usually these will be on lines that were changed, but just not on this PR since itās finding issues that werenāt previously enforced correctly.)
Iām going ahead and merging this since itās been sitting for a while, seems safe, and should be particularly helpful with future PRs.
This switches from JSHint and JSCS to ESLint. My primary goal here was to solve several security vulnerabilities, but I also discovered some places previous rules were not being applied (!). This attempts to follow the same settings the project previously had for JSCS and JSHint.
Fixes #85 and also fixes all security warnings when running
npm install
š~Note: this is a draft because ESLint picks up on some things the previous linter was missing, and I want to see the errors get logged nicely in CI before fixing them.~ (Edit: this is done.)