dbader / node-datadog-metrics

Buffered metrics reporting via the DataDog HTTP API
https://dbader.org/blog/monitoring-your-nodejs-app-with-datadog
MIT License
142 stars 58 forks source link

Normalize new syntax from recent PRs #78

Closed Mr0grog closed 2 years ago

Mr0grog commented 2 years ago

This is a quick pass at updating some of the syntax to match newer language features I used in recent PRs (#69, #71):

This does not cover larger syntactical/structural changes, like:

Those are probably better suited to a separate PR, but I can also do them here if we think it makes more sense.

Mr0grog commented 2 years ago

Don't merge! Found a bug, adding a test to cover it.

Mr0grog commented 2 years ago

Fixed — I modified all the metrics to include a copy of their tags on the flushed results, so an aggregator or reporter that edits one tag list can’t accidentally change other flushed metrics at the same time.