search

dbader / node-datadog-metrics

Buffered metrics reporting via the DataDog HTTP API
https://dbader.org/blog/monitoring-your-nodejs-app-with-datadog
MIT License
142 stars 58 forks source link

Fix linting tools/scripts #85

Closed Mr0grog closed 2 years ago

Mr0grog commented 2 years ago

This repo currently depends on JSCS and JSHint for styling/linting, but in #74 I discovered those no longer work: they are configured not to support the syntax we are currently using and always throw errors, and JSCS has not been maintained for more than half a decade (it merged with ESLint)!

We should update configurations to work, or switch to a maintained set of tools, like ESLint or Prettier.

On a similar note, it would be good to add a .editorconfig file, too.

Mr0grog commented 2 years ago

I got the current tools (JSCS and JSHint) working and added a .editorconfig file in #92, which resolves the highest priority part of this (now we have lint checks on pull requests).

The remaining thing to do here is drop JSCS, but I think there’s less of a rush on that. The most straightforward thing is probably to switch to ESLint, but if we do that, we should also drop JSHint, since ESLint covers what we used both JSCS and JSHint for.

Mr0grog commented 2 years ago

Took a slightly closer look here and also discovered JSHint is configured to use a bunch of rules that are deprecated (because they are style focused). I think that adds to the argument that both JSCS and JSHint should be dropped and replaced with ESLint, which does both jobs.