WIP: Vararg - Githubissues

dbaelz / Konclik

Konclik: Kotlin/Native Command Line Interface Kit

Apache License 2.0

46 stars 4 forks source link

WIP: Vararg #10

Closed DrewCarlson closed 3 years ago

DrewCarlson commented 5 years ago

@dbaelz Thoughts on something like this for varargs? Still needs proper validation and better tests.

dbaelz commented 5 years ago

Hi, thanks for the PR. I have some ideas how to improve and change the varArgs. Do you want to go further with the PR or should I start changing it?

DrewCarlson commented 5 years ago

👍 It's all yours.

dbaelz commented 5 years ago

I haven't changed anything since I'm still unsure with some local decision/changes.

In the next two weeks I'm busy with work, a conference and a holiday afterwards. So don't be disappointed if there's little progress. After that, I'm focusing on this PR and the open issues.

dbaelz commented 5 years ago

Hi, sorry it took me a while to get back to doing stuff for Konclik. Had a really busy time in November. Finally, I reviewed the PR and fixed some the naming locally. So there are some questions and open points:

Could you give me access to the PR, so I could change it in here?
I understand the code, but the use case is a little bit blurry. Can you explain it to me with an example?
There are some tests missing and we should improve the error handling. I'll tackle them in the next days.