search

dbalatero / VimMode.spoon

Adds vim keybindings to all OS X inputs
688 stars 30 forks source link

Update installer with `brew install --cask` #77

Closed jltml closed 3 years ago

jltml commented 3 years ago

Hi!

brew cask was deprecated in favor of brew (with --cask when necessary), so the install-Hammerspoon-from-Homebrew step in the install script doesn't work anymore. This just fixes the line that contains the old brew cask install hammerspoon and replaces it with brew install --cask hammerspoon. You may wish to test it just to be safe — I used the original script once, so when I reran this fixed version, it didn't do everything from scratch (but it all looked good to me nonetheless).

Also — thank you so much for making this :) it's really, really awesome! 🎉

dbalatero commented 3 years ago

Ah good to know the API changed! And thanks for including a PR with the bug report; it makes it really easy to just merge it in!

jltml commented 3 years ago

You're welcome! This is kind of exciting; it's my first pull request on an actual thing (although I don't know if changing two words really counts; haha)… thanks so much!