dbaldwin / DronePan

DronePan - 360 aerial panoramas with DJI Inspire 1, Phantom 3/4, Mavic Pro and Osmo
http://www.dronepan.com
Other
104 stars 32 forks source link

Sky row naming #72

Closed chrissearle closed 8 years ago

chrissearle commented 8 years ago

Is the name "Sky Row" misleading? What we're saying is "allow it to go above (osmo -> below) the horizon. But - it's not a single row - if we allow above the horizon and also more than 3 rows (so 4 with the sky row) - we evenly space the rows - so more than one is above the horizon.

Actually - I'd like to change the behaviour so that it doesn't increase the row count - it's just a flag to say "start at horizontal" or "start at gimbal pitch limit".

chrissearle commented 8 years ago

Thinking this should be a toggle:

(switch upper limit to lower limit for handheld).

Only issue is we'd need to feed the limit from the gimbal object into settings to show it.

Then number of rows is just "how many rows spaced evenly from the chosen limit.

dbaldwin commented 8 years ago

I think that makes sense. Perhaps as additional clarification we can dynamically display the row spacing in degrees. For example:

chrissearle commented 8 years ago

Related to #74