TiShadow iOS App disconnects on every bundle unpacking

dbankier / TiShadow

Quick Titanium previews across devices

http://tishadow.yydigital.com

Other

385 stars 122 forks source link

TiShadow iOS App disconnects on every bundle unpacking #490

Closed ulizama closed 8 years ago

ulizama commented 8 years ago

I downloaded the TiShadow iOS App, I'm able to connect to my TiShadow server correctly, but everytime I send a: tishadow run or tishadow run --update

The app disconnects when it unpacks the content:

DEBUG] A socket connected
[INFO] [CONTROLLER] Connected
[INFO] New Bundle: /Users/ulizama/Documents/Apps/DesignerApp/build/tishadow/dist/Designer.zip | Designer
[DEBUG] Bundle requested.
[INFO] [iphone, 9.3.1, 192.168.1.68] Unpacking new bundle: Designer
[WARN] [iphone, 9.3.1, 192.168.1.68] Disconnected

I have to restart the app and when it launches the updated contents are there.

I have the latest TiShadow version installed directly from the repo:

tishadow -v
2.8.6

dbankier commented 8 years ago

Arghh! Looks like Ti.App._restart() isn't available in the app store build. It is meant to disconnect and reconnect after the restart.

Working on a fix now.

dbankier commented 8 years ago

This: https://github.com/appcelerator/titanium_mobile/blob/master/iphone/Classes/AppModule.m#L35

dbankier commented 8 years ago

Submitting update now.

dbankier commented 8 years ago

Ok. Update went through, but it looks like I need to remove these two as well:

https://github.com/appcelerator/titanium_mobile/blob/415bd6c66dcc55b1a59a59574f3babd3c3a84ede/iphone/Classes/TiRootViewController.h#L69 https://github.com/appcelerator/titanium_mobile/blob/415bd6c66dcc55b1a59a59574f3babd3c3a84ede/iphone/Classes/TiRootViewController.m#L756

Can anyone see anything else I'm missing...

dbankier commented 8 years ago

Found one more, resubmitting... Sorry for this. Fortunately the App Store turnaround time is faster these days...

dbankier commented 8 years ago

Verified with adhoc build. This one should be good.

acaland commented 8 years ago

Did you update to 5.2.2.GA too?

jasonkneen commented 8 years ago

This is working better for me -- but still getting an issue when trying to do a file chance and using @ run --update, the device goes blank and disconnects

dbankier commented 8 years ago

@jasonkneen. Yep. That's what the next update which I sent to app store this morning is about. This comment: https://github.com/dbankier/TiShadow/issues/490#issuecomment-220206258 explains it. I hadn't expected appc to pull out all the _restart stuff from the production build (which they hadn't when I tried in the past). There were a few places I need to hack. The next update should work.

jasonkneen commented 8 years ago

Got it -- thanks

dbankier commented 8 years ago

Ok. We are up and running. The latest update is released and works. It is running 5.2.2.GA. Have fun playing, educating, etc. Be sure to tries those things that you might haven't yet (if you have just been using express mode). Repl, pipe2repl, spies, screenshots, webpage, tests, etc...