search

dbankier / TiShadow

Quick Titanium previews across devices
http://tishadow.yydigital.com
Other
385 stars 122 forks source link

Does not compile with Titanium SDK v7.3.0GA #546

Closed yahya-uddin closed 6 years ago

yahya-uddin commented 6 years ago

When compiling using the latest version of Titanium: v7.3.0 for Android, I get the following error:

[ERROR] C:/Users/yahya/Documents/apps/tishadowapp/Resources/lib/should.js: Property key of ObjectMethod expected node to be of a type ["Identifier","StringLiteral","NumericLiteral"] but instead got "BinaryExpression"

I didn't test this on iOS, but I assume the same issue would occur.

Note there is no problem with v7.2

dbankier commented 6 years ago

Update to the latest version of tishadow

On Sat., 25 Aug. 2018, 12:56 am Yahya Uddin, notifications@github.com wrote:

When compiling using the latest version of Titanium: v7.3.0 for Android, I get the following error:

[ERROR] C:/Users/yahya/Documents/apps/tishadowapp/Resources/lib/should.js: Property key of ObjectMethod expected node to be of a type ["Identifier","StringLiteral","NumericLiteral"] but instead got "BinaryExpression"

I didn't test this on iOS, but I assume the same issue would occur.

Note there is no problem with v7.2

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dbankier/TiShadow/issues/546, or mute the thread https://github.com/notifications/unsubscribe-auth/AAxN3ZiOUNCpuYHXcYghiHUlwa1GHdhXks5uUHZ-gaJpZM4WMCsf .

yahya-uddin commented 6 years ago

Thanks the new update solved the issue. Can we also make the upgrade command actually say if the application is upgrading, as currently it always says "Upgrdaing App..." regardless if a new update is done or not. Hence I do not know if I should re-compile.