search

dbankier / vscode-instant-markdown

vscode extension for instant markdown previews
53 stars 23 forks source link

Feature request: Add option to prevent the preview window from closing #40

Closed calzakk closed 6 years ago

calzakk commented 6 years ago

When switching to a non-markdown file, the preview window automatically closes. When frequently switching between markdown and non-markdown files, the preview window will open and close, and this can get really annoying! And it's even worse if the browser has no other open tabs ;)

Instead of closing straight away, maybe the preview can stay open as long as Code is still open? (It can always be manually closed, of course.)

dbankier commented 6 years ago

Makes sense. Would be a pretty quick fix. PR?

calzakk commented 6 years ago

Thanks for this David, much appreciated!

I'm seeing an issue though: when switching to a non-markdown file with autoCloseServerAndBrowser disabled, the browser indeed stays open, but going back to the markdown file and editing it doesn't cause the changes to appear in the browser.

Closing the browser doesn't help, I have to close and reopen Code for the browser preview to start working again. This happens on both Windows and Linux.

dbankier commented 6 years ago

Yep sorry. Just fixed it. Pushing out new version 1.4.1 now.

calzakk commented 6 years ago

Looks like it's working nicely now, thanks very much :)