dbankier / vscode-instant-markdown

vscode extension for instant markdown previews
53 stars 23 forks source link

Plugin DOSd my system! #7

Closed leegee closed 7 years ago

leegee commented 7 years ago
Extension Author Version
Bookmarks alefragnani 0.10.2
vscode-eslint dbaeumer 1.2.2
vscode-instant-markdown dbankier 0.2.1
docthis joelday 0.3.9
vscode-exec-node miramac 0.2.1
joinlines webdokkeren 1.1.1

I've been using the plug-in for many months, without a problem.

Jut now I opened an .md file to edit, and noticed my machine's fan was spinning up — then noticed that there were many, many tabs open in Chrome, all coming from this plugin.

I shut VSCode, and pressed CTRL+W perhaps 100 times to close as many tabs.

Re-opened VSCode, re-opened the .md file, and then got two tabs opened by the plugin.

Closed the document and repeated with the same results.

Closed the document, re-opened and now get now tab.

Is there a log I could attach?

NB THis is the latest Insiders build of VSCode.

dbankier commented 7 years ago

Sorry about that!

This extensions is just a simple wrapper around https://github.com/suan/instant-markdown-d. The extension code is really quite basic. If you step through it, all it does is try to send the contents of the markdown file to instant-markdown-d when it opens or the file is modified (the update() function). If it gets a connection error, it assumes that the services is not running and tries to initialise() it. When instant-markdown-d starts it opens a browser window (on osx). Based on this, either the insider build sending multiple events simultaneously or something is killing the server startup (it runs on 8090).

Hope that helps.

leegee commented 7 years ago

Has the issue now been fixed?

On 30 January 2017 at 01:27, David Bankier notifications@github.com wrote:

Closed #7 https://github.com/dbankier/vscode-instant-markdown/issues/7 via 5713f48 https://github.com/dbankier/vscode-instant-markdown/commit/5713f483fc021c5ab074f87121a9d0c77327e1f5 .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dbankier/vscode-instant-markdown/issues/7#event-940724526, or mute the thread https://github.com/notifications/unsubscribe-auth/AAfTMHdRVBSbqc9dJpjs9EpEel7dDoBCks5rXS5WgaJpZM4LgjwK .

dbankier commented 7 years ago

Yep. Should be.

On Mon, 30 Jan 2017, 7:12 PM Lee Goddard notifications@github.com wrote:

Has the issue now been fixed?

On 30 January 2017 at 01:27, David Bankier notifications@github.com wrote:

Closed #7 https://github.com/dbankier/vscode-instant-markdown/issues/7 via 5713f48 < https://github.com/dbankier/vscode-instant-markdown/commit/5713f483fc021c5ab074f87121a9d0c77327e1f5

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/dbankier/vscode-instant-markdown/issues/7#event-940724526 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AAfTMHdRVBSbqc9dJpjs9EpEel7dDoBCks5rXS5WgaJpZM4LgjwK

.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/dbankier/vscode-instant-markdown/issues/7#issuecomment-276001328, or mute the thread https://github.com/notifications/unsubscribe-auth/AAxN3XFadyVOg-JN5xuqrAjZjd9PB2GXks5rXZt3gaJpZM4LgjwK .

leegee commented 7 years ago

Super, thanks.

On 30 January 2017 at 09:15, David Bankier notifications@github.com wrote:

Yep. Should be.

On Mon, 30 Jan 2017, 7:12 PM Lee Goddard notifications@github.com wrote:

Has the issue now been fixed?

On 30 January 2017 at 01:27, David Bankier notifications@github.com wrote:

Closed #7 https://github.com/dbankier/vscode-instant-markdown/ issues/7 via 5713f48 < https://github.com/dbankier/vscode-instant-markdown/commit/ 5713f483fc021c5ab074f87121a9d0c77327e1f5

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/dbankier/vscode-instant-markdown/ issues/7#event-940724526 , or mute the thread < https://github.com/notifications/unsubscribe-auth/ AAfTMHdRVBSbqc9dJpjs9EpEel7dDoBCks5rXS5WgaJpZM4LgjwK

.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/dbankier/vscode-instant-markdown/ issues/7#issuecomment-276001328, or mute the thread https://github.com/notifications/unsubscribe-auth/AAxN3XFadyVOg- JN5xuqrAjZjd9PB2GXks5rXZt3gaJpZM4LgjwK .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dbankier/vscode-instant-markdown/issues/7#issuecomment-276001687, or mute the thread https://github.com/notifications/unsubscribe-auth/AAfTMC9z9jjNVAPYhMH_HvjCM8t732Deks5rXZwGgaJpZM4LgjwK .