Fixed issue with duplicate filters

dbaq / angular-emoji-filter-hd

An AngularJS filter for replacing emoji codes with high-definition emoticons (Retina friendly).

Other

39 stars 16 forks source link

Fixed issue with duplicate filters #2

Closed thoughtpalette closed 10 years ago

thoughtpalette commented 10 years ago

Had an issue where I had multiple filters being applied while passing in an object. This filter conflicts with another due to returning a message in $sce.trustAsHtml then emoji filter being ran after.

May not be an essential PR.

dbaq commented 10 years ago

Why closing this?

Also you committed these files

dist/emoji.min.css
dist/emoji.min.js

if you want to reopen your PR, could you update your commit please.

thoughtpalette commented 10 years ago

I ended up forking this to my co's github and forking that just in case this doesn't get merged. I assumed we'll request a PR from that account :}

Also had another change that's not in here.

dbaq commented 10 years ago

Ok. Thanks for contributing!