dbaq / angular-emoji-filter-hd

An AngularJS filter for replacing emoji codes with high-definition emoticons (Retina friendly).
Other
39 stars 16 forks source link

input now returns if passed object #3

Closed thoughtpalette closed 10 years ago

thoughtpalette commented 10 years ago

Had an issue where I had multiple filters being applied while passing in an object. This filter conflicts with another due to returning a message in $sce.trustAsHtml then emoji filter being ran after.

@dbaq Reopening now with updates. Also added bower folder to ignore. Sorry about the confusion!

dbaq commented 10 years ago

Sounds good, the only thing is that you committed the dist/ files. Could you please update your commits? It is just cleaner if they are not in your PR.

Thanks for your contribution.

screen shot 2014-11-06 at 11 49 10 am

thoughtpalette commented 10 years ago

Ahh, I ran the default task assuming you wanted those created in the PR. I'll update it.

thoughtpalette commented 10 years ago

Should be good @dbaq Thanks! :beer:

dbaq commented 10 years ago

Awesome, I'll push the dist files tonight.

Thanks again :beers: