search

dbaranger / InteractionPoweR

InteractionPoweR: Power analysis for interactions via simulation in R
GNU General Public License v3.0
20 stars 1 forks source link

Skew functionality still in tutorial paper and OSF materials/code #4

Closed statisfactions closed 1 year ago

statisfactions commented 1 year ago

The PsyArXiv tuorial, OSF supplementary material, and OSF R code all still contain references to the ability to simulate varying skew and/or the defunct skew.x1 and skew.x2 variables.

I recognize this is not really a bug with the package as is, since I see that you deliberately removed this functionality. It took me a little while to figure out what was going on, so I'm just adding this issue for your and other's reference.

One option would be to deprecate the options with a warning in case others are trying to use this code.

dbaranger commented 1 year ago

Hi! Sorry this happened. We are in the middle of responding to reviews, so some things are not in sync (the manuscript is still being edited). I appreciate the suggestion of adding the deprecate errors. I'll look into adding that to the next release. Thanks for using the software! David

statisfactions commented 1 year ago

Good luck with the review process, and thank you for the (much-needed) software!

Ethan

dbaranger commented 1 year ago

The latest version now issues an informative error if the user supplies a skew.