search

dbartholomae / middy-middleware-class-validator

A middy validation middleware using class-validator.
MIT License
13 stars 5 forks source link

Feat 27 validate query params #28

Closed arjupba closed 2 months ago

dbartholomae commented 5 months ago

Thanks! It looks like you also changed prettier config which then changed all files with formatting changes. Could you please reduce the PR to just the changes needed for the new feature? Thanks! :)

arjupba commented 5 months ago

Thanks! It looks like you also changed prettier config which then changed all files with formatting changes. Could you please reduce the PR to just the changes needed for the new feature? Thanks! :)

I've reduced the changes. It contains new feature. Fix for test cases. Some packages version upgraded to fix peer dependency issue.

arjupba commented 4 months ago

Pushed the changes as per the review comments. Please check @dbartholomae

dbartholomae commented 4 months ago

@arjupba thanks for the help and the pointers! I took the opportunity to update all the dependencies, introduce prettier instead of prettier-standard and overall brought the repo to a modern state. You should now only need to add the actual feature and not make any other changes.

Please note that I changed the main branch to be called main now and I also added CLA assistant to cover the legal side of open source: https://cla-assistant.io/dbartholomae/middy-middleware-class-validator

Please let me know in case you run into any trouble!

CLAassistant commented 4 months ago

CLA assistant check
All committers have signed the CLA.

arjupba commented 4 months ago

Hi @dbartholomae, I've done the changes. Please check this PR. Actually, I need to add few more changes which will enhance the library. So, if you don't want to create unnecessary versions, please merge it to a release branch and let me know. I will create the next PR to the release branch and let's merge it to main once everything is done.

arjupba commented 4 months ago

Hi Daniel, I've done the review comments. Please take a look. I've reduced the branch coverage to 90. It's because we're not getting 100% branch coverage even if we added test cases for all scenarios. JFYI.

github-actions[bot] commented 2 months ago

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.