dbashford / mimosa-server-template-compile

A mimosa module for compiling server templates as part of a build
3 stars 1 forks source link

Error with Validators in 0.7.3 #2

Closed semperos closed 11 years ago

semperos commented 11 years ago

I get the following with version 0.3.0 of server-template-compile using version 0.7.3 of Mimosa:

/home/semperos/opt/nvm/v0.8.16/lib/node_modules/mimosa/node_modules/mimosa-server-template-compile/config.coffee:33
    if (validators.ifExistsIsObject(errors, "serverTemplate config", config.se
                   ^
TypeError: Cannot call method 'ifExistsIsObject' of undefined
    at Object.exports.validate (/home/semperos/opt/nvm/v0.8.16/lib/node_modules/mimosa/node_modules/mimosa-server-template-compile/config.coffee:33:20)
    at MimosaConfigurer._validateSettings (/home/semperos/opt/nvm/v0.8.16/lib/node_modules/mimosa/lib/util/configurer.coffee:122:28)
    at MimosaConfigurer.applyAndValidateDefaults (/home/semperos/opt/nvm/v0.8.16/lib/node_modules/mimosa/lib/util/configurer.coffee:52:23)
    at processModule (/home/semperos/opt/nvm/v0.8.16/lib/node_modules/mimosa/lib/modules/index.coffee:83:16)
    at processModule (/home/semperos/opt/nvm/v0.8.16/lib/node_modules/mimosa/lib/modules/index.coffee:107:16)
    at processModule (/home/semperos/opt/nvm/v0.8.16/lib/node_modules/mimosa/lib/modules/index.coffee:107:16)
    at processModule (/home/semperos/opt/nvm/v0.8.16/lib/node_modules/mimosa/lib/modules/index.coffee:107:16)
    at processModule (/home/semperos/opt/nvm/v0.8.16/lib/node_modules/mimosa/lib/modules/index.coffee:107:16)
    at processModule (/home/semperos/opt/nvm/v0.8.16/lib/node_modules/mimosa/lib/modules/index.coffee:107:16)
    at processModule (/home/semperos/opt/nvm/v0.8.16/lib/node_modules/mimosa/lib/modules/index.coffee:107:16)
make: *** [clean] Error 1
dbashford commented 11 years ago

That is to be expected, as indicated in the latest mimosa release notes. Latest versions of modules won't work with old versions of Mimosa. Keeping everything constantly backward compatible is a bridge too far.

semperos commented 11 years ago

Agreed.

However, I'll take this opportunity to say that it'd be great if modules threw a meaningful error when installed if they're being installed into a version of Mimosa below their minimum-required version.