dbbs-lab / bsb-core

The Brain Scaffold Builder
https://bsb.readthedocs.io
GNU General Public License v3.0
21 stars 16 forks source link

Combine morphology extension information with PS rotation information #337

Open Helveg opened 2 years ago

Helveg commented 2 years ago

In the current temporary implementation if get_region_of_interest of intersectional connectivity strategies we only consider the extension of morphologies as they occur in the MR, and ignore the fact that they could be rotated as dictated by the PS.

I list this as an issue as I'm skipping it while I work to get the proof of concept of parallel connectivity working, but this should obviously be fixed :)

Helveg commented 2 years ago

The difficulty is weighing these 3 things against each other:

Given enough anisotropic rotations, there will be no speedup after going through the effort to calculate rotations: it will practically be the sphere given by the point with max euclidean distance from the origin. So likely, only in very particular cases such as the cerebellar granule cell is the isotropy strong enough to actually benefit from this.

Perhaps a better solution is to allow an isotropic flag on the morphology metadata or cell type for alternative strategies