search

dbbs-lab / bsb-core

The Brain Scaffold Builder
https://bsb.readthedocs.io
GNU General Public License v3.0
22 stars 16 forks source link

Add config.property type validation #681

Closed drodarie closed 10 months ago

drodarie commented 1 year ago

Generally, check what incorrect input to mask_source does. In a more general sense, config properties lose most type validation, perhaps they could be improved to still do type casting before handing values to the setter?

Originally posted by @Helveg in https://github.com/dbbs-lab/bsb/issues/679#issuecomment-1436940187

Helveg commented 1 year ago

Was this added? In which PR?

drodarie commented 1 year ago

This one #687. For some reason merging it did not close the issue.

Helveg commented 1 year ago

Ah, you have to repeat the "closes" for each ticket: "closes #1, closes #2", ...

Helveg commented 1 year ago

I don't see any changes relevant to this issue in that PR though. No changes were made to the config system. To be clear, this issue tracks that input given to setters of config.property are still typecast/validated