search

dbbs-lab / bsb-core

The Brain Scaffold Builder
https://bsb.readthedocs.io
GNU General Public License v3.0
21 stars 16 forks source link

Change struct_id and struct_name to optional #795

Closed filimarc closed 7 months ago

filimarc commented 8 months ago

Changed AllenStructure attributes to optional

List which issues this resolves:

closes #772

Tasks

Helveg commented 8 months ago

Add tests

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b04d5e4) 83.71% compared to head (1945559) 83.81%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #795 +/- ## ========================================== + Coverage 83.71% 83.81% +0.10% ========================================== Files 105 105 Lines 12940 12977 +37 ========================================== + Hits 10833 10877 +44 + Misses 2107 2100 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

filimarc commented 7 months ago

I think all the changes are done, i do not see any pending action here.