dbbs-lab / bsb-core

The Brain Scaffold Builder
https://bsb.readthedocs.io
GNU General Public License v3.0
21 stars 16 forks source link

Switch to multi-simulation adapters by default #804

Closed Helveg closed 7 months ago

Helveg commented 7 months ago

Describe the work done

Breaking change: The adapter.simulate and adapter.run signatures are now expected to handle vararg *simulations, and to return an array of results. Passing multiple simulations should try to run these simulations in the same "world" (e.g. for NEURON/NEST to simply instantiate all given simulation components into global state, so that they run simultaneously, and for Arbor to compose and run the recipes)

List which issues this resolves:

Tasks

codecov[bot] commented 7 months ago

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (3ff5268) 83.81% compared to head (8c0fb34) 83.76%.

Files Patch % Lines
bsb/simulation/adapter.py 59.09% 18 Missing :warning:
bsb/reporting.py 33.33% 6 Missing :warning:
bsb/simulation/_backends.py 62.50% 3 Missing :warning:
bsb/option.py 33.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #804 +/- ## ========================================== - Coverage 83.81% 83.76% -0.06% ========================================== Files 105 105 Lines 12977 13008 +31 ========================================== + Hits 10877 10896 +19 - Misses 2100 2112 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.