search

dbbs-lab / bsb-core

The Brain Scaffold Builder
https://bsb.readthedocs.io
GNU General Public License v3.0
22 stars 16 forks source link

Fix `count_ratio` estimation #824

Closed drodarie closed 8 months ago

drodarie commented 8 months ago

List which issues this resolves:

Fixes #822

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.89%. Comparing base (f6e8eae) to head (b4b9c82).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #824 +/- ## ========================================== + Coverage 86.73% 86.89% +0.15% ========================================== Files 100 100 Lines 13345 13407 +62 ========================================== + Hits 11575 11650 +75 + Misses 1770 1757 -13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

drodarie commented 8 months ago

I split the tests on guess and renamed them to make what is tested explicit. For the cascade test, I wonder if the different indicator should be split since the change on one should not affect the other?

Helveg commented 8 months ago

@drodarie If you're not planning to change the tests any further, feel free to merge this! :)

drodarie commented 8 months ago

Sorry for the delay, based on your feedback, I would like to refactor and extend the tests.