Closed drodarie closed 3 months ago
Realized this version does not work neither ðŸ˜
My solution in the fill
function of ConfigurationDictAttribute
and ConfigurationListAttribute
expose __inv__
as a static attribute of the class not of its instance.
Back to draft board.
Realized this version does not work neither 😠My solution in the
fill
function ofConfigurationDictAttribute
andConfigurationListAttribute
expose__inv__
as a static attribute of the class not of its instance. Back to draft board.
Yea, I mentioned this in my review:
you can not set this on the class, ypu must set this on an instance, otherwise you are setting a global shared inv for all conf list attributes
Could you resolve all conversations of my previous review?
Describe the work done
ConfigurationDictAttribute
andConfigurationListAttribute
fill
function to expose their children__inv__
function.PackageRequirement
_inv__
functionCodeDependencyNode
usages. Now it fetches a python file or a module based on provided string.test_placement
List which issues this resolves:
close #842
Tasks
CodeDependencyNode
andPackageRequirement
CodeDependencyNode
Note
@Helveg mentioned in #843 that
tree_of
should not have anelif
as it could happen that the result of__tree__
is not yet fully parsed but then this fails the test:test_configuration.test_code_dependency_node
. I would need some feedback on the current implementation