Fix/requirements second version

drodarie commented 3 months ago

Describe the work done

Change ConfigurationDictAttribute and ConfigurationListAttribute fill function to expose their children __inv__ function.
Change PackageRequirement _inv__ function
Extend and document CodeDependencyNode usages. Now it fetches a python file or a module based on provided string.
Fix README links
Fix test_placement

List which issues this resolves:

close #842

Tasks

[x] Added tests for CodeDependencyNode and PackageRequirement
[x] Updated documentation of CodeDependencyNode

Note

@Helveg mentioned in #843 that tree_of should not have an elif as it could happen that the result of __tree__ is not yet fully parsed but then this fails the test: test_configuration.test_code_dependency_node. I would need some feedback on the current implementation

drodarie commented 3 months ago

Realized this version does not work neither 😭 My solution in the fill function of ConfigurationDictAttribute and ConfigurationListAttribute expose __inv__ as a static attribute of the class not of its instance. Back to draft board.

Helveg commented 3 months ago

Realized this version does not work neither 😭 My solution in the fill function of ConfigurationDictAttribute and ConfigurationListAttribute expose __inv__ as a static attribute of the class not of its instance. Back to draft board.

Yea, I mentioned this in my review:

you can not set this on the class, ypu must set this on an instance, otherwise you are setting a global shared inv for all conf list attributes

Could you resolve all conversations of my previous review?

dbbs-lab / bsb-core