search

dbcli / litecli

CLI for SQLite Databases with auto-completion and syntax highlighting
https://litecli.com
BSD 3-Clause "New" or "Revised" License
2.52k stars 74 forks source link

sqlparse-0.4.1 support #104

Closed blshkv closed 3 years ago

blshkv commented 3 years ago

The latest version 1.4.1 works fine with sqlparse 0.3.x but fails with 0.4.x:

   from litecli.main import LiteCli
  File "/usr/lib/python3.7/site-packages/litecli/main.py", line 36, in <module>
    from .sqlcompleter import SQLCompleter
  File "/usr/lib/python3.7/site-packages/litecli/sqlcompleter.py", line 9, in <module>
    from .packages.completion_engine import suggest_type
  File "/usr/lib/python3.7/site-packages/litecli/packages/completion_engine.py", line 5, in <module>
    from sqlparse.compat import text_type
ModuleNotFoundError: No module named 'sqlparse.compat'
frenzymadness commented 3 years ago

I see that the compatibility with the latest sqlparse is already fixed in https://github.com/dbcli/litecli/commit/37957e401d22f88800bbdec2c690e731f2cc13bd Could you please release a new version?

amjith commented 3 years ago

Done!

blshkv commented 3 years ago

I suggest to fix setup.py as well and add sqlparse>=0.4.0 <0.5