search

dbcli / litecli

CLI for SQLite Databases with auto-completion and syntax highlighting
https://litecli.com
BSD 3-Clause "New" or "Revised" License
2.06k stars 67 forks source link

Use sqlite3 API to cancel running queries #166

Closed mjpieters closed 9 months ago

mjpieters commented 9 months ago

This fixes #164.

Since the interrupt handler was the only code that referenced sqlexecute.connection_id, and the connection ids is merely a random UUID without any meaning, the code generating that UUID can be removed as well.

codecov-commenter commented 9 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@a4aa7cd). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #166 +/- ## ======================================= Coverage ? 62.09% ======================================= Files ? 23 Lines ? 2018 Branches ? 0 ======================================= Hits ? 1253 Misses ? 765 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mjpieters commented 9 months ago

I've rebased this PR onto my #167 PR; you can review the changes in this PR alone by selecting a single commit on the commits or files changed tabs.

If you choose to merge #167 first, I'll rebase this PR onto master.

mjpieters commented 9 months ago

Rebased now that #167 has been merged.

amjith commented 9 months ago

Looks good! Thank you!

🍨