dbcli / litecli

CLI for SQLite Databases with auto-completion and syntax highlighting
https://litecli.com
BSD 3-Clause "New" or "Revised" License
2.06k stars 67 forks source link

Add basic Debian packaging #175

Closed joshuaboniface closed 2 months ago

joshuaboniface commented 2 months ago

Description

Adds a basic Debian package as requested in the install page. From my quick tests this should cover everything but I'm not 100% sure if every dependency is explicitly defined yet (my system did have a lot of packages pre-installed), a quick review of that would be appreciated.

There's also some changes that should be made but I wanted to propose this first and then ask what the values should be after. Please see the forthcoming review comments below for the specifics.

Checklist

amjith commented 2 months ago

@joshuaboniface Thank you for taking the time to put together this PR. We've tried creating debian/rpm packages as part of our usual release in other projects and failed for multiple reasons.

I've now resorted to having package managers release DEB artifacts using their own repo/CI and moved away from maintaining code in this repo to do that.

I'm not saying. you need to fork litecli to do this but both pgcli and mycli have DEB maintainers who will generate artifacts on a regular cadence on their own schedule instead of tying it to the release cadence of their respective projects.

joshuaboniface commented 2 months ago

@amjith Fair enough. That process requires an actual DD to adopt and become a maintainer, which definitely hasn't happened yet, and I'm not one, so if this isn't something you want to maintain that might be a long-time coming unless you know those maintainers and they're willing to adopt litecli too. No hard feelings I whipped this together fairly quickly for my own reasons as much as anything so if it's not something you want to include in the codebase that's OK!

amjith commented 2 months ago

I'm not ready to take maintainership of the debian package. It is definitely not my forte.

I do appreciate that you felt motivated to make this PR. Thank you!