dbcli / litecli

CLI for SQLite Databases with auto-completion and syntax highlighting
https://litecli.com
BSD 3-Clause "New" or "Revised" License
2.12k stars 68 forks source link

Fixed the 'pager' config variable. Was not picking up any user-supplied #52

Closed reverendpaco closed 5 years ago

reverendpaco commented 5 years ago

pager variable because the read_my_cnf_files method was expecting a setting section called 'client' instead of 'main'.

Other functional callers to the read_my_cnf_files method/function seem not to be affected by this probelm, most notably the prompt config which manually overrode the None returned in lines 116-188 where after not finding prompt_cnf would use c["main"]["prompt"]

Tests seem to pass.

Description

Checklist

codecov-io commented 5 years ago

Codecov Report

Merging #52 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #52   +/-   ##
=======================================
  Coverage   67.91%   67.91%           
=======================================
  Files          21       21           
  Lines        1312     1312           
=======================================
  Hits          891      891           
  Misses        421      421

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 11a68b4...64efeb3. Read the comment docs.

amjith commented 5 years ago

Thank you!