search

dbcli / litecli

CLI for SQLite Databases with auto-completion and syntax highlighting
https://litecli.com
BSD 3-Clause "New" or "Revised" License
2.52k stars 74 forks source link

Add NULLS FIRST and NULLS LAST to keywords. #92

Closed amjith closed 4 years ago

amjith commented 4 years ago

Description

Fixes #86

Add two new keyword completions NULLS FIRST and NULLS LAST. I've also fixed the broken completion for ORDER BY. Previously it was suggesting keywords after the ORDER BY keyword, now it is fixed.

A test was added to ensure the ORDER BY completion doesn't break in the future.

Checklist

codecov-commenter commented 4 years ago

Codecov Report

Merging #92 into master will decrease coverage by 5.44%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
- Coverage   67.80%   62.36%   -5.45%     
==========================================
  Files          21       23       +2     
  Lines        1401     1937     +536     
==========================================
+ Hits          950     1208     +258     
- Misses        451      729     +278
Impacted Files Coverage Δ
litecli/sqlcompleter.py 81.50% <ø> (ø)
litecli/packages/completion_engine.py 87.95% <100.00%> (ø)
litecli/main.py 48.03% <0.00%> (ø)
litecli/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2898615...2286ca3. Read the comment docs.