PEP 8 fixes for mssql_cli.py + others

dbcli / mssql-cli

A command-line client for SQL Server with auto-completion and syntax highlighting

BSD 3-Clause "New" or "Revised" License

1.36k stars 191 forks source link

PEP 8 fixes for mssql_cli.py + others #329

Closed ellbosch closed 4 years ago

ellbosch commented 4 years ago

This PR fixes code violating PEP 8 for mssql_cli.py and it's dependencies.

kevcunnane commented 4 years ago

@ellbosch do we know why integration tests failed?

ellbosch commented 4 years ago

@ellbosch do we know why integration tests failed?

The Windows build failure will be fixed with the upcoming PR. The Linux failure looks like one of our pre-existing flaky tests but more investigation is needed.

kevcunnane commented 4 years ago

Given the discussion on Exception handling I'm happy to sign off since worst case is a slightly less helpful error message on exit due to unexpected errors. Please resolve integration tests but otherwise looks good