PEP 8 changes in mssqlcli folder

dbcli / mssql-cli

A command-line client for SQL Server with auto-completion and syntax highlighting

BSD 3-Clause "New" or "Revised" License

1.35k stars 191 forks source link

PEP 8 changes in mssqlcli folder #336

Closed ellbosch closed 4 years ago

ellbosch commented 4 years ago

Tag: #283

lgtm-com[bot] commented 4 years ago

This pull request fixes 11 alerts when merging 3aab8a6071a7b3d3682cd6e6e8e3442c81aa0b3b into 9f7e99ab33d80b4ae17099df48fc0ea0394a7149 - view on LGTM.com

fixed alerts:

4 for Except block handles 'BaseException'
4 for Unused import
2 for Module is imported with 'import' and 'import from'
1 for Module is imported more than once

lgtm-com[bot] commented 4 years ago

This pull request fixes 11 alerts when merging 5f3c95acb53c03da1e361e91573237756e38f512 into 9f7e99ab33d80b4ae17099df48fc0ea0394a7149 - view on LGTM.com

fixed alerts:

4 for Except block handles 'BaseException'
4 for Unused import
2 for Module is imported with 'import' and 'import from'
1 for Module is imported more than once

chlafreniere commented 4 years ago

Can you help me understand which changes are required for PEP 8 compliance and which aren't?

For example, removing a parameter from a constructor (line 10 in the first file) doesn't seem to fix anything on LGTM.

ellbosch commented 4 years ago

Can you help me understand which changes are required for PEP 8 compliance and which aren't?

For example, removing a parameter from a constructor (line 10 in the first file) doesn't seem to fix anything on LGTM.

Truthfully, it's PEP 8 plus other stuff. General code cleanup. I'm going through each issue that's picked up from pylint, which includes PEP 8.

lgtm-com[bot] commented 4 years ago

This pull request fixes 11 alerts when merging cd4e046c860053e9d16700d5c20a601ae7b1d57f into 9f7e99ab33d80b4ae17099df48fc0ea0394a7149 - view on LGTM.com

fixed alerts:

4 for Except block handles 'BaseException'
4 for Unused import
2 for Module is imported with 'import' and 'import from'
1 for Module is imported more than once

lgtm-com[bot] commented 4 years ago

This pull request fixes 11 alerts when merging 49d7a7fcde5426262d3089343463709e7d1fcd89 into e61e287dae80987427b1e83251c821040c5f4d78 - view on LGTM.com

fixed alerts:

4 for Except block handles 'BaseException'
4 for Unused import
2 for Module is imported with 'import' and 'import from'
1 for Module is imported more than once

lgtm-com[bot] commented 4 years ago

This pull request fixes 11 alerts when merging c0d0b885ccc3a315a3c24d12923c951512f37b3a into e61e287dae80987427b1e83251c821040c5f4d78 - view on LGTM.com

fixed alerts:

4 for Except block handles 'BaseException'
4 for Unused import
2 for Module is imported with 'import' and 'import from'
1 for Module is imported more than once