refactored client testing

dbcli / mssql-cli

A command-line client for SQL Server with auto-completion and syntax highlighting

BSD 3-Clause "New" or "Revised" License

1.36k stars 191 forks source link

Closed ellbosch closed 4 years ago

ellbosch commented 4 years ago

Fixes #279.

This PR refactors our testing of the mssqlcli client. Changes include:

Introduction of pytest fixtures for safe creation/teardown and readability
Organization of tests into separate classes to isolate write workloads/improved readability
Use of try/finally blocks for safe teardown

The diff is a huge mess so I'll leave comments throughout to explain changes.